Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Docs #580

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Type Docs #580

merged 2 commits into from
Apr 24, 2024

Conversation

priyankakmEaton
Copy link
Contributor

Fixes #5680

Changes proposed in this Pull Request:

  • completeRegistration action has incorrect params / param types defined in the various docs
  • update userData type to object
  • remove 2 extra params validationCode and validationEmail

Screenshots / Screen Recording (if applicable)

To Test:

Any specific feedback you are looking for?

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Apr 19, 2024
Copy link

github-actions bot commented Apr 19, 2024

Visit the preview URL for this PR (updated for commit ed9268c):

https://blui-react-login--pr580-bug-5680-typedocs-r6sk02df.web.app

(expires Fri, 26 Apr 2024 13:19:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1e9064d2e35ed37fe01e053587ea5f209719a043

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 66 does not make sense, as we have removed validationCode from completeRegistration

Copy link
Collaborator

@surajeaton surajeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other things look good.

@surajeaton surajeaton merged commit c01b1d8 into dev Apr 24, 2024
6 checks passed
@surajeaton surajeaton deleted the bug/5680_typeDocs branch April 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

2 participants